Feature: added silent song notification setting #1129
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
No need for the additional toggle setting. Just set it to silent by default - I don't see a use case where having a notification sound played on song change is necessary. This also removes the need to add localization. |
| interface PlayListDurationBadgeProps { | ||
| time?: null | number; | ||
| } | ||
|
|
||
| const PlayListDurationBadge = ({ time }: PlayListDurationBadgeProps) => { | ||
| if (time === null || time === undefined) return <SpinnerIcon />; | ||
| return <Badge>{dayjs(time).format('HH:mm:ss')}</Badge>; | ||
| }; | ||
|
|
There was a problem hiding this comment.
Please open a separate PR for this, since it's unrelated to the notifications.
There was a problem hiding this comment.
you're right, I made a little mistake, sorry 😅
src/i18n/locales/it.json
Outdated
| "albumBackground_description": "aggiunge un'immagine di sfondo per le pagine degli album contenenti l'album art", | ||
| "albumBackgroundBlur": "intensità sfocatura immagine di sfondo dell'album", | ||
| "albumBackgroundBlur_description": "regola la quantità di sfocatura applicata all'immagine di sfondo dell'album", | ||
|
|
|
This should probably be rebased/squashed to remove the 8 unnecessary commits. |
I could close this one and open another one with a single commit |
|
No need, it can be squashed via the GitHub merge process. |
I added this setting to mute the default sound that the system notification emits when another song is played.
The setting is only visible when the “Enable song notification” setting is enabled, under the Playback section.
2025-09-15.20-33-51.mp4