fix: electron menu bar for darwin devices #1113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
jeffvli
requested changes
Sep 10, 2025
1ba2ef3 to
567944c
Compare
567944c to
58a36b3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since @jeffvli's commit 20debb0 in the v0.20.0, it completely disabled any
cmd+keyshortcut in the entire app, including quit, copy, paste, select all, and so on :(screenshots without and with the fix)
Since the menu bar is not included in the electron window on Darwin devices, issue #1041 does not apply and is therefore a regression.
I fixed this by applying menu bar masking only to non-Darwin devices.
I usedsetMenuBarVisibilityto allow non-Darwin users who wish to do so to use the menu bar if necessary. By default, it will be invisible and can be redisplayed using theAltkey.This restores all shortcuts and benefits in terms of convenience and accessibility.
Not to mention: it allows you to paste extremely complicated passwords from password managers when entering server information, for example.