Skip to content

Conversation

@mihawk90
Copy link
Contributor

@mihawk90 mihawk90 commented Sep 8, 2025

This does a slight cleanup on the Now playing notifications as mentioned on Discord:

  • The notification text isn't localised and would be a general PITA to localise in the first place
  • The whole point of this notification showing up is that the song is now playing, meaning "Now playing" in the text is redundant and therefore unnecessary
  • I don't know any other music player notification that shows this, for reference this is DeaDBeeF:
    image
  • Formatted the layout to mimic the in-player Now Playing display

Note I didn't test this with Feishin itself cause I don't currently have a setup to actually compile it, but I did test the strings with notify-send and it worked just fine:
image

Tested with CI artifact and works as expected.
Can't test Windows or Mac though.

@vercel
Copy link

vercel bot commented Sep 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
feishin Ready Ready Preview Comment Sep 8, 2025 3:35pm

@jeffvli jeffvli merged commit be6ec49 into jeffvli:development Sep 10, 2025
5 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 8, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants