fix: ensure autoplay on metadata duration mismatch causing decoding error #1095
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
f4224b1 to
2d2b1d5
Compare
2d2b1d5 to
59e01f9
Compare
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've consistently had issues where it does not move on to the next song in the playlist/queue.
It turns out an error is being thrown when it reached the end of a track due to mismatch between the metadata's duration and the actual duration, resulting in a decoding error.
This fix will progress to the next track if there's an error within the final second of a song.
Potentially fixes #550 / #577 / #927 / #1063 / other stale issues I've seen.