Skip to content

chore(ci): use pr-closer action#664

Merged
jdx merged 3 commits into
mainfrom
chore/use-pr-closer-action
Jun 4, 2026
Merged

chore(ci): use pr-closer action#664
jdx merged 3 commits into
mainfrom
chore/use-pr-closer-action

Conversation

@jdx

@jdx jdx commented Jun 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • replace the inline pr-closer workflow script with the shared jdx/pr-closer action
  • keep the existing daily schedule and manual dispatch trigger
  • grant issue/comment and status permissions needed by the shared action

Tests

  • actionlint .github/workflows/pr-closer.yml

This PR was generated by an AI coding assistant.


Note

Low Risk
CI-only change; stale-PR behavior now depends on the external action matching prior rules, but no application or security-sensitive code is touched.

Overview
Replaces the daily stale-PR workflow’s inline gh/jq script with the pinned reusable action jdx/pr-closer@v1.0.1, while keeping the same midnight cron, workflow_dispatch, and concurrency settings.

The job is renamed to pr-closer, and issues: write is added alongside existing PR/check/status permissions so the action can manage comments or related issue APIs as needed.

Reviewed by Cursor Bugbot for commit d2acc43. Bugbot is set up for automated code reviews on this repo. Configure here.

Summary by CodeRabbit

  • Chores
    • Updated pull request management workflow with improved automation for handling stale pull requests.

@coderabbitai

coderabbitai Bot commented Jun 4, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

The stale PR closer workflow is simplified by replacing a custom job with inline bash logic that identifies and closes stale pull requests with a single invocation of the jdx/pr-closer@v1 external action. Job-level permissions are explicitly defined, removing prior custom environment variable configuration.

Changes

Stale PR Closer Workflow Simplification

Layer / File(s) Summary
Replace custom bash job with external action
.github/workflows/pr-closer.yml
Job name changes from close-stale-prs to pr-closer, implementation delegates to jdx/pr-closer@v1 action instead of inline gh + jq bash, and explicit per-job permissions replace workflow-level defaults.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

Poem

🐰 A bash script once toiled in the dark,
With gh and jq leaving their mark,
But now a trim action takes its place,
Closing stale PRs with newfound grace!

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title 'chore(ci): use pr-closer action' directly and clearly summarizes the main change: replacing inline pr-closer logic with the pr-closer GitHub Action.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/use-pr-closer-action

Comment @coderabbitai help to get the list of available commands and usage tips.

@greptile-apps

greptile-apps Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

Replaces the inline stale-PR shell/jq script with the shared jdx/pr-closer@44b9e78 (v1.0.1) action, keeping the same daily cron and manual dispatch triggers.

  • The action reference is pinned to a full commit SHA with a version comment, following security best practices.
  • issues: write is added to the job permissions as required by the shared action.
  • The job is renamed from close-stale-prs to pr-closer; all stale-PR selection logic now lives in the shared action rather than inline.

Confidence Score: 5/5

Safe to merge — the only file changed is a CI workflow that delegates to a commit-SHA-pinned shared action.

The change is a straightforward delegation to a well-pinned external action owned by the same author. The action SHA is explicit, permissions are appropriately scoped, and the triggers are unchanged. No logic runs in this repo anymore that could fail in a new way.

No files require special attention.

Important Files Changed

Filename Overview
.github/workflows/pr-closer.yml Replaces inline shell/jq script with pinned jdx/pr-closer@44b9e78 (v1.0.1); adds issues: write permission; job renamed to pr-closer

Reviews (3): Last reviewed commit: "Merge branch 'main' into chore/use-pr-cl..." | Re-trigger Greptile

Comment thread .github/workflows/pr-closer.yml Outdated
@codecov

codecov Bot commented Jun 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 73.59%. Comparing base (f1d2c96) to head (d2acc43).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   73.59%   73.59%           
=======================================
  Files          50       50           
  Lines        7824     7824           
  Branches     7824     7824           
=======================================
  Hits         5758     5758           
  Misses       1334     1334           
  Partials      732      732           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jdx jdx merged commit 163804e into main Jun 4, 2026
9 checks passed
@jdx jdx deleted the chore/use-pr-closer-action branch June 4, 2026 17:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant