Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request serves as a release chore, updating the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
Greptile SummaryThis is an automated release PR generated by Key points:
Confidence Score: 4/5
Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[release-plz triggers release] --> B[Bump version 0.2.2 → 0.3.0]
B --> C[Update Cargo.toml]
B --> D[Update Cargo.lock]
B --> E[Update CHANGELOG.md]
C & D & E --> F[PR #50 merged]
F --> G[Publish pklr v0.3.0 to crates.io]
G --> H{Downstream users upgrade}
H -->|Read CHANGELOG| I[See only 'Added: converters support']
H -->|Compile code| J[⚠ ObjectSource struct literal breaks if type_name missing]
Reviews (1): Last reviewed commit: "chore: release v0.3.0" | Re-trigger Greptile |
| ## [0.3.0](https://github.com/jdx/pklr/compare/v0.2.2...v0.3.0) - 2026-03-24 | ||
|
|
||
| ### Added | ||
|
|
||
| - implement output.renderer.converters support ([#49](https://github.com/jdx/pklr/pull/49)) |
There was a problem hiding this comment.
Breaking change not documented in CHANGELOG
The PR description and cargo-semver-checks output confirm there is an API breaking change in this release — a new pub field type_name was added to the ObjectSource struct in src/value.rs, which is a source-incompatible change for users constructing that struct with literal syntax.
However, the v0.3.0 changelog entry only includes an ### Added section and makes no mention of this breaking change. Downstream users relying on CHANGELOG.md to understand upgrade requirements will not be aware that their code may fail to compile after upgrading.
Consider adding a ### Breaking Changes (or ### Changed) section, for example:
| ## [0.3.0](https://github.com/jdx/pklr/compare/v0.2.2...v0.3.0) - 2026-03-24 | |
| ### Added | |
| - implement output.renderer.converters support ([#49](https://github.com/jdx/pklr/pull/49)) | |
| ## [0.3.0](https://github.com/jdx/pklr/compare/v0.2.2...v0.3.0) - 2026-03-24 | |
| ### Breaking Changes | |
| - `ObjectSource` struct has a new `pub` field `type_name`; existing struct-literal constructions must be updated ([#49](https://github.com/jdx/pklr/pull/49)) | |
| ### Added | |
| - implement output.renderer.converters support ([#49](https://github.com/jdx/pklr/pull/49)) |
There was a problem hiding this comment.
Code Review
This pull request updates the project version to 0.3.0 across Cargo.toml, Cargo.lock, and CHANGELOG.md, and adds an entry for output.renderer.converters support. The primary feedback is to document a breaking API change related to the ObjectSource struct in the CHANGELOG.md under a new Changed section, adhering to Keep a Changelog conventions.
| ### Added | ||
|
|
||
| - implement output.renderer.converters support ([#49](https://github.com/jdx/pklr/pull/49)) |
There was a problem hiding this comment.
This release includes breaking API changes, as noted in the pull request description. It would be beneficial for users to have these documented in the changelog. According to Keep a Changelog conventions, breaking changes are typically listed under a Changed section.
I suggest adding a Changed section to highlight the breaking change related to the ObjectSource struct.
| ### Added | |
| - implement output.renderer.converters support ([#49](https://github.com/jdx/pklr/pull/49)) | |
| ### Added | |
| - implement output.renderer.converters support ([#49](https://github.com/jdx/pklr/pull/49)) | |
| ### Changed | |
| - **(breaking)** The `ObjectSource` struct has a new public field `type_name`. This is an API breaking change for consumers constructing this struct directly. |
🤖 New release
pklr: 0.2.2 -> 0.3.0 (⚠ API breaking changes)⚠
pklrbreaking changesChangelog
This PR was generated with release-plz.