feat: add macOS code signing to release workflow#173
Merged
Conversation
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds macOS code signing to the release workflow to ensure binaries are properly signed for distribution. The implementation follows the same approach used in the fnox project.
Changes:
- Import code signing certificates for macOS builds using
apple-actions/import-codesign-certs@v3 - Split binary upload step into separate macOS (signed) and non-macOS paths
- Configure code signing with Developer ID Application certificate and bundle prefix
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| codesign: "Developer ID Application: Jeffrey Dickey (4993Y37DX6)" | ||
| codesign_prefix: dev.jdx. | ||
| - name: Upload binary (non-macOS) | ||
| if: ${{ !startsWith(matrix.os, 'macos') }} |
There was a problem hiding this comment.
The conditional expression has unnecessary double braces. The outer ${{ }} wrapper is redundant when using the if key in GitHub Actions. Remove the outer braces for consistency with line 51.
Suggested change
| if: ${{ !startsWith(matrix.os, 'macos') }} | |
| if: !startsWith(matrix.os, 'macos') |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
apple-actions/import-codesign-certs@v3for certificate importtaiki-e/upload-rust-binary-action@v1with codesign parametersRequired Secrets
Before this works, you need to add these GitHub repository secrets:
CERTIFICATES_P12- Base64-encoded.p12certificate file containing your Developer ID Application certificateCERTIFICATES_P12_PASS- Password for the.p12fileHow to export and set up secrets
.p12with a passwordbase64 -i certificate.p12 | pbcopy🤖 Generated with Claude Code
Note
Adds macOS code signing to the release workflow and conditionally uploads signed binaries for Apple targets.
apple-actions/import-codesign-certs@v3usingCERTIFICATES_P12andCERTIFICATES_P12_PASSUpload binary (macOS signed)withcodesignandcodesign_prefixforpitchfork, andUpload binary (non-macOS)for othersWritten by Cursor Bugbot for commit 203a4ca. This will update automatically on new commits. Configure here.