ci: enable MISE_PRERELEASES so the new prerelease field populates#140
ci: enable MISE_PRERELEASES so the new prerelease field populates#140
prerelease field populates#140Conversation
…pulates Sibling to #135. That PR plumbed `prerelease = true` through the TOML pipeline, but on its own the field is dead code: `mise ls-remote --json` filters pre-release tags out before emitting JSON unless the caller has opted in. With ~900 tools, per-tool config isn't viable. jdx/mise#9415 adds a global `MISE_PRERELEASES` env var that flips the filter for every tool at once. Setting it at the workflow env level covers the host-side `mise ls-remote --json` call in `generate_toml_file` (the JSON path that actually feeds `generate-toml.js`). Forwarding `-e MISE_PRERELEASES` into the Docker container covers the plain-text `docker run jdxcode/mise -y ls-remote` call in `fetch()`. Optimistic: requires a mise release containing jdx/mise#9415 in the host mise installed by `aube install`/`mise.run`, and a rebuild of the `jdxcode/mise` image for the Docker call. Until both ship, the env var is silently ignored — same TOML output as today, no regression. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
Warning You have reached your daily quota limit. Please wait up to 24 hours and I will start processing your requests again! |
Greptile SummaryThis PR enables Confidence Score: 5/5Safe to merge — change is backwards-compatible and silently no-ops until upstream mise ships #9415. Two-line change across two files, both following established patterns in the repo. No logic errors, no security concerns, and the PR description clearly explains the sequencing dependency. Until the upstream feature ships, the env var is ignored and output is identical to today. No files require special attention. Important Files Changed
Sequence DiagramsequenceDiagram
participant GHA as GitHub Actions (update.yml)
participant SH as update.sh
participant Host as Host mise (ls-remote --json)
participant Docker as Docker jdxcode/mise (ls-remote)
participant TOML as generate-toml.js
GHA->>GHA: Set MISE_PRERELEASES=1 (workflow env)
GHA->>SH: Run update.sh
alt JSON path (generate_toml_file)
SH->>Host: mise ls-remote --json
Note over Host: MISE_PRERELEASES=1 inherited from workflow env
Host-->>SH: JSON with prerelease flags
SH->>TOML: Pass JSON
TOML-->>SH: TOML with prerelease=true
else Plain-text path (fetch)
SH->>Docker: docker run -e MISE_PRERELEASES jdxcode/mise ls-remote
Note over Docker: MISE_PRERELEASES=1 forwarded via -e flag
Docker-->>SH: Plain-text versions list
end
Reviews (1): Last reviewed commit: "ci: enable MISE_PRERELEASES so the new `..." | Re-trigger Greptile |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit b8f30b5. Configure here.
| # emitting JSON and the rendered TOML never gets the new `prerelease` | ||
| # field that scripts/generate-toml.js plumbs through (#135). Requires | ||
| # mise >= the release containing jdx/mise#9415. | ||
| MISE_PRERELEASES: "1" |
There was a problem hiding this comment.
Workflow-wide env var may install prerelease CI tools
Medium Severity
MISE_PRERELEASES is set at the workflow-level env: block, making it active during all steps — including jdx/mise-action and aube install, which resolve and install CI tools from mise.toml. That file specifies latest for several tools (aube, fd, shellcheck, shfmt, etc.) and "24" for node. Once the upstream mise release containing jdx/mise#9415 ships, MISE_PRERELEASES=1 will cause those version specifiers to potentially resolve to pre-release/unstable versions, risking CI breakage. Moving MISE_PRERELEASES to the step-level env: on the update.sh step (alongside PARALLEL_FETCHES) would scope the effect to only the intended ls-remote calls.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit b8f30b5. Configure here.
There was a problem hiding this comment.
Currently, the Railway build system are using gradle 9.6.0 Pre release build to build the system due to this bug mentioned here. If #143 is not effective in fixing this regression, do we have any plan to address it?
Packages
──────────
java │ 25.0.2 │ RAILPACK_JDK_VERSION (25)
gradle │ 9.6.0-M1 │ gradle-wrapper.properties (9)


Summary
Sibling to #135. That PR plumbed
prerelease = truethrough the TOML pipeline, but on its own the field is dead code:mise ls-remote --jsonfilters pre-release tags out before emitting JSON unless the caller has opted in. With ~900 tools, per-tool config isn't viable.jdx/mise#9415 adds a global
MISE_PRERELEASESenv var (and a matching--prereleaseCLI flag) that flips the filter for every tool at once.Changes
.github/workflows/update.yml— setMISE_PRERELEASES: "1"at the job env level. Covers the host-sidemise ls-remote --jsoncall ingenerate_toml_file(the JSON path that actually feedsgenerate-toml.js).scripts/update.sh— forward-e MISE_PRERELEASESinto the Docker container. Covers the plain-textdocker run jdxcode/mise -y ls-remotecall infetch().Verification (after deploy)
After the next run, expect to see
prerelease = trueflags on tools whose upstream releases are flagged as pre-releases — e.g. tools with-rc1/-beta/-dev.NGitHub releases. Until then: zero hits, despite #135 being merged. Confirmed against the most recent run (24968319913) which touched 646 tools through the JSON path with zeroprerelease = trueflags emitted.Sequencing
Optimistic — depends on:
prereleasessetting and--prereleaseflag mise#9415 in the host mise installed byaube install/mise.run. (Today's host mise = v2026.4.23, which has #9329 but not #9415.)jdxcode/miseDocker image with the same release for the plain-text fallback path.Until both ship,
MISE_PRERELEASESis silently ignored — same TOML output as today, no regression. Safe to merge whenever; it activates on its own as soon as the upstream pieces land.Note
Low Risk
Low risk: only toggles an environment flag and forwards it into the Dockerized
mise ls-remotecall, changing which versions are included but not altering control flow or security-sensitive logic.Overview
Enables global inclusion of prerelease tags during the automated versions update run by setting
MISE_PRERELEASES=1in theupdateGitHub Actions workflow.Also forwards
MISE_PRERELEASESinto thedocker run jdxcode/mise ... ls-remoteinvocation inscripts/update.sh, allowing downstream TOML generation to populate the newprerelease = truemetadata when upstream marks releases as prereleases.Reviewed by Cursor Bugbot for commit b8f30b5. Bugbot is set up for automated code reviews on this repo. Configure here.