Greptile Summary

This PR centralizes install_before timestamp resolution into a new install_before::resolve_before_date helper, removes the old effective_before_date from tool_request.rs, and carries the computed cutoff on ToolVersion.before_date so every consumer (toolset install, install-into, backends) reads from one source of truth. The refactoring is clean and the test coverage (unit tests in install_before.rs, new test_inline_install_before_wins_over_config_entry in backend/mod.rs) is solid.

Confidence Score: 5/5

Safe to merge — the refactoring is logically equivalent to the previous code for all identified code paths, and prior thread concerns about inline-opts precedence and the None branch in install_into.rs are correctly resolved in this revision.

No new P0/P1 issues found. The effective_latest_before_date now explicitly checks ba().opts() before config.get_tool_opts(), fixing the precedence concern from earlier thread iterations. All remaining findings are P2 or already noted in previous comments. The new unit tests give good confidence the logic is correct.

No files require special attention.

Important Files Changed

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[ToolRequest::resolve] --> B[ToolVersion::resolve]
    B --> C[resolve_before_date]
    C --> D{opts.before_date set?}
    D -- Yes --> E[Use CLI override]
    D -- No --> F{per-tool install_before set?}
    F -- Yes --> G[Parse per-tool option]
    F -- No --> H{Settings::install_before set?}
    H -- Yes --> I[Parse global setting]
    H -- No --> J[None]
    E & G & I & J --> K[tv.before_date on ToolVersion]
    K --> L[InstallContext.before_date]
    K --> M[backend latest_version]
    M --> N[effective_latest_before_date]
    N --> O{before_date already set?}
    O -- Yes --> P[Use it]
    O -- No --> Q{ba opts install_before?}
    Q -- Yes --> R[Inline opts highest precedence]
    Q -- No --> S{config tool opts install_before?}
    S -- Yes --> T[Config file opts]
    S -- No --> U[resolve_before_date global fallback]

_{Reviews (9): Last reviewed commit: "fix(backend): preserve inline install_be..." | Re-trigger Greptile}

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.