chore: release 2026.4.1#8840
Conversation
There was a problem hiding this comment.
Code Review
This pull request bumps the version of mise to 2026.4.1 and updates several packages in the Aqua Registry, including claude-code, delta, goreleaser, and zellij, while adding dockerfile-pin. Review feedback identifies several configuration issues in the registry YAML files: incorrect asset naming and architecture mappings for dockerfile-pin, missing Linux replacements and incorrect Darwin architecture overrides for delta, overly restrictive environment support for delta, and breaking architecture replacements for legacy versions of zellij.
| - version_constraint: "true" | ||
| asset: dockerfile-pin_{{.OS}}_{{.Arch}}.{{.Format}} | ||
| format: tar.gz | ||
| checksum: | ||
| type: github_release | ||
| asset: checksums.txt | ||
| algorithm: sha256 | ||
| overrides: | ||
| - goos: windows | ||
| format: zip |
There was a problem hiding this comment.
The asset naming configuration for dockerfile-pin does not match the actual release assets on GitHub. The OS names are capitalized (e.g., Darwin, Linux), amd64 is represented as x86_64, and the Darwin asset uses all as the architecture instead of a specific one. This will cause installation failures on all platforms.
- version_constraint: "true"
asset: dockerfile-pin_{{title .OS}}_{{.Arch}}.{{.Format}}
format: tar.gz
replacements:
amd64: x86_64
checksum:
type: github_release
asset: checksums.txt
algorithm: sha256
overrides:
- goos: darwin
asset: dockerfile-pin_{{title .OS}}_all.{{.Format}}
- goos: windows
format: zip| replacements: | ||
| amd64: x86_64 | ||
| arm64: aarch64 | ||
| darwin: apple-darwin | ||
| windows: pc-windows-msvc |
There was a problem hiding this comment.
The linux replacement is missing in this block. Delta releases for Linux use unknown-linux-musl (or unknown-linux-gnu) in the filename. Without this replacement, the tool will attempt to download an asset with -linux in the name, which does not exist.
replacements:
amd64: x86_64
arm64: aarch64
darwin: apple-darwin
linux: unknown-linux-musl
windows: pc-windows-msvc| - goos: darwin | ||
| replacements: | ||
| amd64: amd64 |
There was a problem hiding this comment.
The replacement amd64: amd64 for Darwin is incorrect. Delta releases for macOS consistently use x86_64 (e.g., delta-0.18.2-x86_64-apple-darwin.tar.gz). This override will cause installation failures on Intel-based Macs for future versions matching this constraint.
- goos: darwin
replacements:
arm64: aarch64| supported_envs: | ||
| - linux | ||
| - darwin | ||
| rosetta2: true | ||
| - darwin/arm64 | ||
| - windows/amd64 |
There was a problem hiding this comment.
The supported_envs list is too restrictive. It currently excludes darwin/amd64 (Intel Macs) and linux/arm64, both of which are supported by Delta. It should be expanded to ensure broad compatibility.
supported_envs:
- linux
- darwin
- windows/amd64| replacements: | ||
| amd64: x86_64 | ||
| darwin: macos |
There was a problem hiding this comment.
For Zellij versions <= 0.5.1, the architecture amd64 is used directly in the filename (e.g., zellij-macos-amd64.tar.gz). The replacement amd64: x86_64 introduced here will break the installation for these older versions.
replacements:
darwin: macos
Greptile SummaryThis is a routine patch release (2026.4.0 → 2026.4.1) bumping version strings across all packaging files and updating several aqua registry entries. The registry changes include a new Confidence Score: 5/5Safe to merge; all remaining findings are P2 quality notes that do not block the release. Only one P2 concern: the zellij refactor drops the intentional crates/aqua-registry/aqua-registry/pkgs/zellij-org/zellij/registry.yaml — confirm whether zellij now ships checksums for v0.43.1+ before relying on default checksum behavior. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["aqua backend: install zellij"] --> B{version_constraint eval}
B -->|"Version == v0.1.0-alpha"| C["asset: mosaic-x86_64-linux (raw)\nlinux/amd64 only"]
B -->|"<= 0.5.1"| D["asset: zellij-OS-ARCH.tar.gz\nlinux/amd64 + darwin"]
B -->|"<= 0.43.1"| E["asset: zellij-ARCH-OS.tar.gz\nlinux + darwin\nno checksum"]
B -->|"true (latest)"| F["asset: zellij-ARCH-OS.tar.gz\nlinux + darwin + windows\nwindows_arm_emulation: true\n⚠️ no checksum.enabled:false"]
E -->|"old config had"| G["checksum: enabled: false\n(zellij has no release checksums)"]
F -.->|"missing"| G
Reviews (5): Last reviewed commit: "chore: release 2026.4.1" | Re-trigger Greptile |
Hyperfine Performance
|
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.0 x -- echo |
21.9 ± 0.4 | 21.0 | 26.3 | 1.00 |
mise x -- echo |
22.4 ± 0.5 | 21.6 | 28.1 | 1.02 ± 0.03 |
mise env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.0 env |
21.6 ± 0.6 | 20.6 | 26.3 | 1.00 |
mise env |
22.0 ± 0.5 | 21.0 | 23.8 | 1.02 ± 0.04 |
mise hook-env
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.0 hook-env |
22.2 ± 0.4 | 21.1 | 24.3 | 1.00 |
mise hook-env |
22.7 ± 0.4 | 21.8 | 24.6 | 1.02 ± 0.02 |
mise ls
| Command | Mean [ms] | Min [ms] | Max [ms] | Relative |
|---|---|---|---|---|
mise-2026.4.0 ls |
21.7 ± 0.4 | 20.9 | 25.4 | 1.00 |
mise ls |
22.3 ± 0.4 | 21.6 | 25.2 | 1.03 ± 0.03 |
xtasks/test/perf
| Command | mise-2026.4.0 | mise | Variance |
|---|---|---|---|
| install (cached) | 149ms | 152ms | -1% |
| ls (cached) | 79ms | 81ms | -2% |
| bin-paths (cached) | 81ms | 82ms | -1% |
| task-ls (cached) | 795ms | 800ms | +0% |
6a1e50d to
64b51e0
Compare
🚀 Features
🐛 Bug Fixes
-qflag inmise preparecommand by @Marukome0743 in #8792📚 Documentation
📦 Registry
New Contributors
📦 Aqua Registry Updates
New Packages (1)
azu/dockerfile-pinUpdated Packages (4)
anthropics/claude-codedandavison/deltagoreleaser/goreleaserzellij-org/zellij