fix(go): use configurable go_repo and retain tags with failed date fetches#7306
Merged
jdx merged 2 commits intofeat/go-created-atfrom Dec 15, 2025
Merged
fix(go): use configurable go_repo and retain tags with failed date fetches#7306jdx merged 2 commits intofeat/go-created-atfrom
jdx merged 2 commits intofeat/go-created-atfrom
Conversation
2 tasks
- Extract repo name from Settings.go_repo instead of hardcoding "golang/go" - Make GithubTagWithDate.date optional to handle fetch failures - Keep all tags in results even when date fetch fails - Upgrade debug to warn when commit date fetch fails Co-authored-by: jdx <216188+jdx@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add created_at support to ls-remote --json
fix(go): use configurable go_repo and retain tags with failed date fetches
Dec 15, 2025
| .trim_start_matches("http://") | ||
| .trim_start_matches("github.com/") | ||
| .trim_end_matches(".git") | ||
| .trim_end_matches('/'); |
There was a problem hiding this comment.
Bug: URL suffix stripping order causes incorrect repo extraction
The order of trim_end_matches(".git") followed by trim_end_matches('/') fails to correctly parse URLs ending with .git/. For example, https://github.com/golang/go.git/ would result in golang/go.git instead of golang/go. Reversing the order (trimming / first, then .git) would handle all combinations correctly. While the default URL works fine, users who configure custom URLs with both suffixes would get incorrect repo names passed to the GitHub API.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go plugin hardcoded "golang/go" instead of using the
MISE_GO_REPOsetting, and silently dropped versions when commit date fetching failed.Changes
Settings.go_repoURL instead of hardcoding "golang/go" in both slow and fast pathsGithubTagWithDate.datetoOption<String>and return tags even when date fetch failsdebug!towarn!when commit date fetching fails💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.
Note
Use configurable Go repo for tag listing and keep all tags even when commit date fetch fails, logging failures at warn level.
src/plugins/core/go.rs):owner/repofromSettings.go_repoURL and uses it for both slow (list_tags_with_dates) and fast (list_tags) paths.VersionInfo.created_atwhen available.src/github.rs):GithubTagWithDate.datetoOption<String>and returns all tags regardless of date fetch success.debug!towarn!on commit date fetch failures.Written by Cursor Bugbot for commit 9bd8dc2. This will update automatically on new commits. Configure here.