feat: add bin option support for archive extraction#6930
Closed
feat: add bin option support for archive extraction#6930
Conversation
risu729
reviewed
Nov 9, 2025
risu729
reviewed
Nov 9, 2025
risu729
approved these changes
Nov 9, 2025
jdx
reviewed
Nov 9, 2025
jdx
reviewed
Nov 9, 2025
Owner
|
needs docs and e2e test |
Contributor
Author
|
why set as draft? |
Owner
|
tests are failing |
- Add support for 'bin' option in install_artifact function - When bin is specified, rename the extracted executable to the given name - Only rename if exactly one executable is found in the archive fixes jdx#6649
5859b16 to
83788ff
Compare
Contributor
Author
|
@jdx fixed |
|
This PR has been open for more than 30 days without activity. Please reopen if you'd like to continue working on it. |
Contributor
Author
|
I can't reopen, but this was pending review @jdx |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #6649
disclaimer: while I know Rust and understand this code, this was 100% LLM generated. I tested the actual problem I had (yt-dlp being named yt-dlp_macos) and it was fixed I haven't done much beyond that.