feat(tasks): change task_config.includes resolution from overriding to additive#6636
Closed
feat(tasks): change task_config.includes resolution from overriding to additive#6636
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR changes the behavior of task_config.includes configuration from overriding to additive, allowing hierarchical task inclusion across configuration files. The change enables child configuration files to inherit and extend task includes from parent configurations rather than completely replacing them.
- Modified task include resolution to be additive rather than override-based
- Updated documentation to clarify the new additive behavior
- Added comprehensive end-to-end test to verify hierarchical task inclusion
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| e2e/tasks/test_task_includes_additive | New test script verifying additive behavior across config hierarchy |
| docs/tasks/task-configuration.md | Updated documentation explaining additive includes behavior |
| docs/tasks/file-tasks.md | Minor documentation update referencing task_config.includes |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While I was reading the code of
task_config.includes, I found some inconsistency in its resolution.For global tasks,
task_config.includesis added per configs, but for local tasks, onlytask_config.includesin the config with the least precedence is included.I think it should at least be overridable, but it would be more intuitive and also make the implementation simple if we change the behaviour from overriding (technically not, it's not overridable) to additive.
This also resolves the inconsistency of task loading orders.
Reverts #6159