Revert "fix: Use arguments for to pass staged filenames to pre-commit task"#3791
Merged
Revert "fix: Use arguments for to pass staged filenames to pre-commit task"#3791
Conversation
… task (#…" This reverts commit d5781be.
This was referenced Dec 22, 2024
Contributor
|
I just noticed this revert - I can see what was wrong - the This is what it should have been to be platform-independent (and correctly in the temp-dir): : "${TMPDIR:=/tmp}"
PIPE=$(mktemp -u "${TMPDIR%/}/mise.{task}.XXXXXXXX")I can make a PR again to fix this (and check the trap logic...), unless you want to stick with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #3492
this is creating a bunch of "mise.pre-commit' files that are annoying to deal with