Feature request: Don't use red when high lighting task prefixes #4142
Replies: 1 comment 10 replies
-
|
it was at one point, but if we do that it would greatly limit the number of colors mise has available because if we remove red we probably should remove yellow for the same reason: Lines 379 to 388 in 6ccb1d9 I think you could create a poll for this and see what people prefer |
Beta Was this translation helpful? Give feedback.
-
|
you're missing my point entirely. I'm saying we can only use those 16 colors the user has because anything else may not look right with their theme. It's the fact that they're customized to the theme which means we can actually use them. |
Beta Was this translation helpful? Give feedback.
-
|
The red color is scares me every time I look at the CI logs lol. Do we really want to have different colors for different tasks? Maybe stick to one color? Or let's say one color for main tasks and one another color for "depends" ones? |
Beta Was this translation helpful? Give feedback.
-
|
Would it make sense to check $TERM and use more colors if they are available? |
Beta Was this translation helpful? Give feedback.
-
|
the issue is not being able to use particular colors, it's that we don't know what the background color is so we can't choose colors that are legible without modifying the background (which I wouldn't want to do). I'd probably accept a PR to remove yellow/red and add modifiers like bold/dim/bright to the other colors. |
Beta Was this translation helpful? Give feedback.
-
|
Hey I'm sorry not a Rust expert here, but did you mean something like this #8782? |
Beta Was this translation helpful? Give feedback.
Uh oh!
There was an error while loading. Please reload this page.
-
Sometimes when running
mise run, mise chooses red for the task prefix which makes me think something is wrong.Could red be excluded from the algorithm that chooses colors for the task prefix?
Beta Was this translation helpful? Give feedback.
All reactions