fix: Enable vendored OpenSSL for cross-compilation#3
Merged
Conversation
Add openssl-sys with vendored feature to fix cross-compilation failures on ARM64 Linux. The vendored feature compiles OpenSSL from source instead of linking to system libraries, which resolves the missing OpenSSL development libraries error during cross-compilation. Fixes the release workflow failure for aarch64-unknown-linux-gnu and x86_64-unknown-linux-gnu targets. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes cross-compilation failures by enabling vendored OpenSSL builds from source, addressing missing OpenSSL development libraries during ARM64 and x86_64 Linux target builds.
Key Changes
- Adds
openssl-sysdependency withvendoredfeature to compile OpenSSL from source - Makes cross-compilation self-contained and independent of system OpenSSL libraries
- Resolves dependency chain issues from fnox → Azure/Google Cloud SDKs → reqwest → native-tls → openssl-sys
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openssl-syswithvendoredfeature to fix cross-compilation failuresProblem
The release workflow was failing when cross-compiling for
aarch64-unknown-linux-gnuandx86_64-unknown-linux-gnutargets because OpenSSL development libraries weren't available for the target platforms.The dependency chain is:
Solution
Enable the
vendoredfeature foropenssl-sys, which compiles OpenSSL from source instead of linking to system libraries. This makes cross-compilation self-contained and independent of system library availability.Test plan
Fixes https://github.com/jdx/fnox/actions/runs/18640611588
🤖 Generated with Claude Code
Note
Enable vendored OpenSSL by adding
openssl-syswithvendoredfeature; update lockfile to includeopenssl-src.openssl-syswithvendoredfeature inCargo.tomlto compile OpenSSL from source.Cargo.lockto includeopenssl-srcand wire it intoopenssl-sys.Written by Cursor Bugbot for commit c830f1a. This will update automatically on new commits. Configure here.