Conversation
a40ad5a to
82507c2
Compare
There was a problem hiding this comment.
Code Review
This pull request increments the version of communique to 1.1.1 in the manifest files and updates the changelog with details on recent fixes. A review comment points out that the new changelog entry is placed out of chronological order, suggesting it should be moved to the top of the file to follow best practices.
|
|
||
| - Reduce repetitive Highlights in generated release notes by tightening the system prompt and tool schema ([#124](https://github.com/jdx/communique/pull/124)) | ||
| - Dedupe the sponsor blurb in communique's own GitHub releases when the workflow re-runs ([#123](https://github.com/jdx/communique/pull/123)) | ||
|
|
There was a problem hiding this comment.
The changelog entries are out of chronological order. Version 1.1.1 is being placed below version 1.1.0. According to Keep a Changelog best practices, newer versions should be placed at the top of the file, immediately below the ## [Unreleased] section.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #125 +/- ##
=======================================
Coverage 94.66% 94.66%
=======================================
Files 26 26
Lines 4708 4708
Branches 4708 4708
=======================================
Hits 4457 4457
Misses 160 160
Partials 91 91 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Greptile SummaryThis is a patch release (v1.1.1) that bumps the version across all artifacts (
Confidence Score: 3/5Safe to merge after fixing the missing newline in CHANGELOG.md that breaks the 1.0.4 section heading. One P1 finding: the 1.0.4 version heading is collapsed onto the preceding bullet, making that changelog section invisible in rendered output. All other changes are clean version-string bumps with no logic involved. CHANGELOG.md — line 21, missing newline before the ## [1.0.4] heading. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A["release-plz workflow triggered"] --> B["Generate release notes\n(tightened system prompt — no redundant Highlights)"]
B --> C["Append sponsor blurb step"]
C --> D{"Existing sponsor section\nin release body?"}
D -- Yes --> E["Strip existing ## 💚 Sponsor communique section"]
E --> F["Append canonical en.dev blurb"]
D -- No --> F
F --> G["Publish GitHub Release v1.1.1"]
Reviews (1): Last reviewed commit: "chore: release v1.1.1" | Re-trigger Greptile |
| - *(generate)* Support `communique generate HEAD --changelog` as an intentional `[Unreleased]` target — replaces the existing `## [Unreleased]` section in place instead of inserting a literal `## [HEAD]` entry, with prompt/title labels switched to "unreleased" wording and an early guard rejecting `HEAD --github-release`. ([#121](https://github.com/jdx/communique/pull/121)) (@ThomasK33) | ||
|
|
||
| ## [1.0.4](https://github.com/jdx/communique/releases/tag/v1.0.4) - 2026-04-24 | ||
| - *(generate)* Support `communique generate HEAD --changelog` as an intentional `[Unreleased]` target — replaces the existing `## [Unreleased]` section in place instead of inserting a literal `## [HEAD]` entry, with prompt/title labels switched to "unreleased" wording and an early guard rejecting `HEAD --github-release`. ([#121](https://github.com/jdx/communique/pull/121)) (@ThomasK33)## [1.0.4](https://github.com/jdx/communique/releases/tag/v1.0.4) - 2026-04-24 |
There was a problem hiding this comment.
The blank line between the 1.1.0 "Added" bullet and the ## [1.0.4] heading was removed by this PR, so the heading is now concatenated onto the tail of the bullet text. Markdown will not parse ## [1.0.4] as a heading when it is glued to the previous line — it just becomes trailing prose on the list item, making the 1.0.4 section invisible in rendered output.
| - *(generate)* Support `communique generate HEAD --changelog` as an intentional `[Unreleased]` target — replaces the existing `## [Unreleased]` section in place instead of inserting a literal `## [HEAD]` entry, with prompt/title labels switched to "unreleased" wording and an early guard rejecting `HEAD --github-release`. ([#121](https://github.com/jdx/communique/pull/121)) (@ThomasK33)## [1.0.4](https://github.com/jdx/communique/releases/tag/v1.0.4) - 2026-04-24 | |
| - *(generate)* Support `communique generate HEAD --changelog` as an intentional `[Unreleased]` target — replaces the existing `## [Unreleased]` section in place instead of inserting a literal `## [HEAD]` entry, with prompt/title labels switched to "unreleased" wording and an early guard rejecting `HEAD --github-release`. ([#121](https://github.com/jdx/communique/pull/121)) (`@ThomasK33`) | |
| ## [1.0.4](https://github.com/jdx/communique/releases/tag/v1.0.4) - 2026-04-24 |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 82507c2. Configure here.
| - *(generate)* Support `communique generate HEAD --changelog` as an intentional `[Unreleased]` target — replaces the existing `## [Unreleased]` section in place instead of inserting a literal `## [HEAD]` entry, with prompt/title labels switched to "unreleased" wording and an early guard rejecting `HEAD --github-release`. ([#121](https://github.com/jdx/communique/pull/121)) (@ThomasK33) | ||
|
|
||
| ## [1.0.4](https://github.com/jdx/communique/releases/tag/v1.0.4) - 2026-04-24 | ||
| - *(generate)* Support `communique generate HEAD --changelog` as an intentional `[Unreleased]` target — replaces the existing `## [Unreleased]` section in place instead of inserting a literal `## [HEAD]` entry, with prompt/title labels switched to "unreleased" wording and an early guard rejecting `HEAD --github-release`. ([#121](https://github.com/jdx/communique/pull/121)) (@ThomasK33)## [1.0.4](https://github.com/jdx/communique/releases/tag/v1.0.4) - 2026-04-24 |
There was a problem hiding this comment.
Missing newline merges section heading into bullet point
Medium Severity
The ## [1.0.4] section heading got concatenated directly onto the end of the preceding bullet point text (after (@ThomasK33)), with no newline separating them. This means ## [1.0.4] and everything beneath it will render as part of the bullet point text rather than as a proper Markdown heading, breaking the changelog's structure for all entries from v1.0.4 downward.
Reviewed by Cursor Bugbot for commit 82507c2. Configure here.
A small patch release that stops generated release notes from saying the same thing three times, and keeps communique's own sponsor footer from compounding on workflow reruns.
Fixed
submit_release_notestool schema have been retightened so the model stops producing a## Highlightssection that just restates the categorized## Added/## Fixedbullets underneath it. The opening summary is now capped at 1-2 sentences, Highlights are gated on "roughly 10+ distinct user-facing changes or 4+ independent headline themes", and the prompt explicitly assigns each section a distinct job: the opening paragraph frames the release, Highlights (when present) group broad themes for skimming, and categorized sections carry the concrete PR links, authors, examples, and compatibility notes. The prompt also tells the model directly to avoid saying the same change three times. Patch and small minor releases should now skip Highlights entirely instead of padding them out. (#124) (@jdx)release-plzworkflow appends a## 💚 Sponsor communiquefooter to each GitHub release. If the workflow re-ran, or if communique itself drafted notes that already included a sponsor section, the footer would stack up. TheAppend en.dev sponsor blurbstep is now idempotent: it strips any existing## 💚 Sponsor communiquesection from the current release body before appending the canonical en.dev blurb. (#123) (@jdx)Note
Low Risk
Low risk: this PR only bumps version metadata and updates generated documentation/changelog; no runtime behavior changes are included in the diff (aside from a potential
CHANGELOG.mdformatting glitch).Overview
Cuts the
v1.1.1release by bumping the crate/CLI version from1.1.0→1.1.1acrossCargo.toml,Cargo.lock, the usage spec, and generated CLI docs.Updates
CHANGELOG.mdwith a new1.1.1entry describing two fixes, though the edit also leaves a formatting issue where the1.1.0entry appears to run into the1.0.4header.Reviewed by Cursor Bugbot for commit 82507c2. Bugbot is set up for automated code reviews on this repo. Configure here.