fix(install): warn on deprecated override refs#859
Conversation
📝 WalkthroughWalkthroughThis PR adds detection for deprecated pnpm dollar-reference syntax in package overrides. A new warning code is defined with metadata, detection logic extracts deprecated ChangesDeprecated Dollar Override Warning
🎯 2 (Simple) | ⏱️ ~10 minutes
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Greptile SummaryAdds an advisory warning (
Confidence Score: 5/5Safe to merge; the change is purely advisory and touches no resolution or mutation logic. The warning is emitted on a read-only pass over the already-merged overrides map and does not alter any data structure, drop behavior, or resolver inputs. The helper function is small and covered by a unit test that exercises the three important cases. All project conventions (error-code registration, tracing emit pattern, docs regeneration) are followed correctly. No files require special attention. Important Files Changed
Reviews (1): Last reviewed commit: "fix(install): warn on deprecated overrid..." | Re-trigger Greptile |
Summary
Tests
Note
Low Risk
Advisory-only tracing during install settings validation; override merge and drop behavior are unchanged.
Overview
Install now surfaces pnpm’s deprecated
$override syntax as an advisory warning while leaving resolution unchanged.After merged
overridesare built inconfigure_resolver, a newdeprecated_dollar_override_refshelper flags values that start with$(excluding bare$) and logsWARN_AUBE_OVERRIDE_DOLLAR_REF_DEPRECATED, pointing users toward catalog entries. The existingWARN_AUBE_OVERRIDE_MISSING_DEPpath for unresolved$refs still runs afterward.The warning is registered in
aube-codesanddocs/error-codes.data.json, with a unit test on the detector.Reviewed by Cursor Bugbot for commit 3363c30. Bugbot is set up for automated code reviews on this repo. Configure here.
Summary by CodeRabbit
New Features
$version reference syntax in package overrides, helping identify and migrate outdated override configurations.Documentation