feat(dialog): close和cancel各司其职#3282
Merged
oasis-cloud merged 3 commits intojdf2e:feat_v3.xfrom Jun 27, 2025
Merged
Conversation
|
""" Walkthrough此次更改主要调整了 Dialog 组件在取消与关闭操作时的回调触发逻辑。取消按钮和关闭图标现在分别只触发各自相关的回调，二者行为被彻底解耦。同时，相关演示文件也同步调整了事件处理方式。 Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (2)
⏰ Context from checks skipped due to timeout of 90000ms (2)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3282 +/- ##
=============================================
- Coverage 87.79% 87.79% -0.01%
=============================================
Files 290 290
Lines 19089 19085 -4
Branches 2939 2936 -3
=============================================
- Hits 16760 16756 -4
Misses 2324 2324
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/packages/dialog/__test__/dialog.spec.tsx (2)
98-119: 关闭图标测试保持正确的回调检验测试正确地验证了点击关闭图标只触发
onClose回调，体现了关闭图标与取消按钮行为的解耦。虽然测试中同时声明了onCancel和onClose，但只检验onClose被调用是正确的。建议：可以考虑添加显式断言来确保
onCancel未被调用，以更明确地验证行为分离：fireEvent.click(closeBtn) expect(onClose).toBeCalled() + expect(onCancel).not.toBeCalled()
6-32: 建议补充beforeCancel回调的测试覆盖当前测试只验证了
onCancel回调，根据AI摘要提到取消按钮现在会触发beforeCancel和onCancel。建议添加对beforeCancel回调的测试以确保完整的功能覆盖。test('show dialog base info display ', async () => { const onCancel = vi.fn() + const beforeCancel = vi.fn() const { container } = render( - <Dialog title="title" data-testid="test" visible onCancel={onCancel}> + <Dialog title="title" data-testid="test" visible onCancel={onCancel} beforeCancel={beforeCancel}> <div>content</div> </Dialog> ) // ... 其他测试代码 ... fireEvent.click(footerCancelEle) expect(onCancel).toBeCalled() + expect(beforeCancel).toBeCalled() })
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
src/packages/dialog/__test__/dialog.spec.tsx(2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: test
🔇 Additional comments (1)
src/packages/dialog/__test__/dialog.spec.tsx (1)
7-31: 测试逻辑更新符合组件行为分离的设计测试正确地将取消按钮的测试从使用
onClose改为使用onCancel，这与组件中取消和关闭操作分离的设计目标一致。测试逻辑准确地验证了点击取消按钮只触发onCancel回调。
oasis-cloud
approved these changes
Jun 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit