fix(overlay): 移除overlay-zIndex，避免zIndex props具备默认值导致css变量无效的使用困惑 by Miles-hxy · Pull Request #3262 · jdf2e/nutui-react

Miles-hxy · 2025-06-11T01:54:57Z

…lue confusion

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充
fork仓库代码是否为最新避免文件冲突
Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

文档
- 移除了 Overlay 组件文档中关于 --nutui-overlay-zIndex CSS 变量的说明。
样式
- 移除了 Overlay 组件相关的 z-index 样式变量及对应样式设置。

…lue confusion

coderabbitai · 2025-06-11T01:55:03Z

Walkthrough

此次变更主要移除了 Overlay 组件中关于 z-index 的 SCSS 变量 $overlay-zIndex 及其对应的 CSS 变量 --nutui-overlay-zIndex，并同步更新了相关文档和样式文件，删除了对该变量的引用及文档说明，未涉及其他功能或结构调整。

Changes

文件/路径	变更摘要
src/packages/overlay/doc.en-US.md src/packages/overlay/doc.md src/packages/overlay/doc.taro.md src/packages/overlay/doc.zh-TW.md	从 Overlay 组件文档中移除了 `--nutui-overlay-zIndex` CSS 变量的说明
src/packages/overlay/overlay.scss	移除了 `.nut-overlay` 类中对 `$overlay-zIndex` 的 z-index 属性引用
src/styles/variables.scss	删除了 `$overlay-zIndex` 变量声明

Poem

叠层遮罩轻轻移，
z-index 悄然别离。
变量清理文档新，
样式整洁更安心。
兔子挥手说再见，
代码世界更清明！
🐇✨

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between d0eaabc and b7b3c4f.

📒 Files selected for processing (6)

src/packages/overlay/doc.en-US.md (0 hunks)
src/packages/overlay/doc.md (0 hunks)
src/packages/overlay/doc.taro.md (0 hunks)
src/packages/overlay/doc.zh-TW.md (0 hunks)
src/packages/overlay/overlay.scss (0 hunks)
src/styles/variables.scss (0 hunks)

💤 Files with no reviewable changes (6)

src/packages/overlay/overlay.scss
src/packages/overlay/doc.en-US.md
src/packages/overlay/doc.md
src/packages/overlay/doc.zh-TW.md
src/packages/overlay/doc.taro.md
src/styles/variables.scss

⏰ Context from checks skipped due to timeout of 90000ms (4)

GitHub Check: test
GitHub Check: build
GitHub Check: test
GitHub Check: lint

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Explain this complex logic.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai explain this code block.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and explain its main purpose.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-06-11T01:56:33Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.75%. Comparing base (d0eaabc) to head (b7b3c4f).
Report is 13 commits behind head on feat_v3.x.

Additional details and impacted files

@@            Coverage Diff             @@
##           feat_v3.x    #3262   +/-   ##
==========================================
  Coverage      87.75%   87.75%           
==========================================
  Files            290      290           
  Lines          19111    19111           
  Branches        2937     2937           
==========================================
  Hits           16770    16770           
  Misses          2336     2336           
  Partials           5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

xiaoyatong · 2025-06-26T06:04:06Z

做一下废弃标注~ 避免现有用户还在用。比如在文档的 zIndex 属性位置，标注下，废弃了样式变量，请使用 zIndex 。

fix: remove -zIndex CSS variable due to lower priority and default va…

b7b3c4f

…lue confusion

pull-request-size bot added the size/XS label Jun 11, 2025

github-actions bot added action:review This PR needs more reviews (less than 2 approvals) 3.x Target branch 3.x labels Jun 11, 2025

Miles-hxy changed the title ~~fix: 移除 $overlay-zIndex CSS 变量，避免因优先级低及默认值导致使用困惑~~ fix: 移除通过overlay-zIndex，避免zIndex props具备默认值导致css变量无效的使用困惑 Jun 11, 2025

Miles-hxy changed the title ~~fix: 移除通过overlay-zIndex，避免zIndex props具备默认值导致css变量无效的使用困惑~~ fix: 移除overlay-zIndex，避免zIndex props具备默认值导致css变量无效的使用困惑 Jun 11, 2025

Miles-hxy requested review from oasis-cloud and xiaoyatong June 11, 2025 01:58

Miles-hxy changed the title ~~fix: 移除overlay-zIndex，避免zIndex props具备默认值导致css变量无效的使用困惑~~ fix(overlay): 移除overlay-zIndex，避免zIndex props具备默认值导致css变量无效的使用困惑 Jun 12, 2025

xiaoyatong merged commit f6f1e06 into jdf2e:feat_v3.x Jun 26, 2025
8 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(overlay): 移除overlay-zIndex，避免zIndex props具备默认值导致css变量无效的使用困惑#3262

fix(overlay): 移除overlay-zIndex，避免zIndex props具备默认值导致css变量无效的使用困惑#3262
xiaoyatong merged 1 commit intojdf2e:feat_v3.xfrom
Miles-hxy:fix_popup_zindex

Miles-hxy commented Jun 11, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Jun 11, 2025 •

edited

Loading

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Jun 11, 2025 •

edited

Loading

Uh oh!

xiaoyatong commented Jun 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

Miles-hxy commented Jun 11, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Poem

Chat

Support

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

xiaoyatong commented Jun 26, 2025

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Miles-hxy commented Jun 11, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Jun 11, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Jun 11, 2025 •

edited

Loading