fix(picker): 解决透传popup的round属性不生效问题 by irisSong · Pull Request #3205 · jdf2e/nutui-react

irisSong · 2025-04-27T10:16:15Z

…nto feat_v3.x

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

⚠️ 请自检并全部勾选全部选项。⚠️

文档已补充或无须补充
代码演示已提供或无须提供
TypeScript 定义已补充或无须补充
fork仓库代码是否为最新避免文件冲突
Files changed 没有 package.json lock 等无关文件

Summary by CodeRabbit

样式
- 移除了选择器组件的背景色设置。

…nto feat_v3.x

coderabbitai · 2025-04-27T10:16:23Z

Walkthrough

本次变更从 picker.scss 样式表的 .nut-picker CSS 类中移除了 background-color: $color-background-overlay; 属性。除此之外，未对其他样式规则或属性进行修改，也未涉及任何导出或公共实体的声明更改。

Changes

文件路径	变更摘要
src/packages/picker/picker.scss	移除了 `.nut-picker` 类的背景色属性。

Suggested reviewers

oasis-cloud

Poem

小兔挥笔改样式，
背景颜色轻轻去，
选择器更显清新意，
CSS 轻盈如春雨。
代码世界常新绿，
跳跃创新乐无比！

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bc1f644 and 27ba192.

📒 Files selected for processing (1)

src/packages/picker/picker.scss (0 hunks)

💤 Files with no reviewable changes (1)

src/packages/picker/picker.scss

⏰ Context from checks skipped due to timeout of 90000ms (2)

GitHub Check: build
GitHub Check: test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

Review comments: Directly reply to a review comment made by CodeRabbit. Example:
- I pushed a fix in commit <commit_id>, please review it.
- Generate unit testing code for this file.
- Open a follow-up GitHub issue for this discussion.
Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
- @coderabbitai generate unit testing code for this file.
- @coderabbitai modularize this function.
PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
- @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
- @coderabbitai read src/utils.ts and generate unit testing code.
- @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
- @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

@coderabbitai pause to pause the reviews on a PR.
@coderabbitai resume to resume the paused reviews.
@coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
@coderabbitai full review to do a full review from scratch and review all the files again.
@coderabbitai summary to regenerate the summary of the PR.
@coderabbitai generate docstrings to generate docstrings for this PR.
@coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
@coderabbitai resolve resolve all the CodeRabbit review comments.
@coderabbitai configuration to show the current CodeRabbit configuration for the repository.
@coderabbitai help to get help.

Other keywords and placeholders

Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (`.coderabbit.yaml`)

You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
Please see the configuration documentation for more information.
If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

Visit our Documentation for detailed information on how to use CodeRabbit.
Join our Discord Community to get help, request features, and share feedback.
Follow us on X/Twitter for updates and announcements.

codecov · 2025-04-27T10:18:06Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (bc1f644) to head (27ba192).
Report is 1 commits behind head on feat_v3.x.

Additional details and impacted files

@@            Coverage Diff             @@
##           feat_v3.x    #3205   +/-   ##
==========================================
  Coverage      86.54%   86.54%           
==========================================
  Files            289      289           
  Lines          18739    18739           
  Branches        2822     2822           
==========================================
  Hits           16217    16217           
  Misses          2517     2517           
  Partials           5        5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

irisSong added 4 commits March 21, 2025 15:23

fix(badge): 解决中文偏上问题

d7e7d86

fix: css 变量更新

532e0e1

Merge branch 'feat_v3.x' of https://github.com/irisSong/nutui-react i…

c912d43

…nto feat_v3.x

fix: 解决picker设置popup的round属性不生效问题

27ba192

pull-request-size bot added the size/XS label Apr 27, 2025

github-actions bot added action:review This PR needs more reviews (less than 2 approvals) 3.x Target branch 3.x labels Apr 27, 2025

xiaoyatong merged commit bd9f30b into jdf2e:feat_v3.x Apr 29, 2025
10 of 11 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(picker): 解决透传popup的round属性不生效问题#3205

fix(picker): 解决透传popup的round属性不生效问题#3205
xiaoyatong merged 4 commits intojdf2e:feat_v3.xfrom
irisSong:bugfix_popup

irisSong commented Apr 27, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

coderabbitai bot commented Apr 27, 2025 •

edited

Loading

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (`.coderabbit.yaml`)

Documentation and Community

Uh oh!

codecov bot commented Apr 27, 2025 •

edited

Loading

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

irisSong commented Apr 27, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🤔 这个变动的性质是？

🔗 相关 Issue

💡 需求背景和解决方案

☑️ 请求合并前的自查清单

Summary by CodeRabbit

Uh oh!

coderabbitai bot commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Suggested reviewers

Poem

Chat

CodeRabbit Commands (Invoked using PR comments)

Other keywords and placeholders

CodeRabbit Configuration File (.coderabbit.yaml)

Documentation and Community

Uh oh!

codecov bot commented Apr 27, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

irisSong commented Apr 27, 2025 •

edited by coderabbitai bot

Loading

coderabbitai bot commented Apr 27, 2025 •

edited

Loading

CodeRabbit Configuration File (`.coderabbit.yaml`)

codecov bot commented Apr 27, 2025 •

edited

Loading