feat(video): 兼容taro Component属性#3185
Merged
irisSong merged 3 commits intojdf2e:feat_v3.xfrom Apr 24, 2025
Merged
Conversation
Walkthrough本次变更扩展了 Changes
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3185 +/- ##
==========================================
Coverage 86.52% 86.53%
==========================================
Files 289 289
Lines 18725 18725
Branches 2819 2819
==========================================
+ Hits 16202 16203 +1
+ Misses 2518 2517 -1
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
irisSong
requested changes
Apr 16, 2025
src/packages/video/video.taro.tsx
Outdated
| autoplay={options.autoplay || autoplay} | ||
| loop={options.loop || loop} | ||
| poster={options.poster || poster} | ||
| controls={controls !== undefined ? controls : options.controls} |
Collaborator
Author
There was a problem hiding this comment.
controls 的值 默认是true。其他的不是。需要处理下 为 control 默认false的情况，也就是 undefined 的情况。
Miles-hxy
reviewed
Apr 16, 2025
src/packages/video/video.taro.tsx
Outdated
| autoplay={options.autoplay || autoplay} | ||
| loop={options.loop || loop} | ||
| poster={options.poster || poster} | ||
| controls={controls !== undefined ? controls : options.controls} |
Collaborator
There was a problem hiding this comment.
controls也是bollean类型，这里是不是和上面一样都用||运算就可以
Miles-hxy
approved these changes
Apr 18, 2025
Miles-hxy
approved these changes
Apr 21, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
文档