fix(image): 组件内部的style处理覆盖传入的className#3165
Merged
oasis-cloud merged 3 commits intojdf2e:feat_v3.xfrom Apr 11, 2025
Merged
Conversation
Walkthrough该 PR 包含两个文件的更新。首先，在 Changes
Sequence Diagram(s)sequenceDiagram
participant ImageComp as Image Component
participant Env as Environment Checker
participant Style as ContainerStyle Builder
participant View as View Renderer
ImageComp->>Env: 检查环境 (是否为 WEB)
Env-->>ImageComp: 返回环境信息
ImageComp->>Style: 根据环境条件构建 containerStyle
Style-->>ImageComp: 返回样式对象
ImageComp->>View: 传递 containerStyle 和条件类名，渲染 View
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
🧰 Additional context used🧬 Code Graph Analysis (1)src/packages/image/image.taro.tsx (1)
⏰ Context from checks skipped due to timeout of 90000ms (1)
🔇 Additional comments (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## feat_v3.x #3165 +/- ##
=============================================
+ Coverage 87.18% 87.19% +0.01%
=============================================
Files 279 279
Lines 18537 18537
Branches 2820 2821 +1
=============================================
+ Hits 16161 16164 +3
+ Misses 2371 2368 -3
Partials 5 5 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
oasis-cloud
approved these changes
Apr 10, 2025
irisSong
approved these changes
Apr 11, 2025
Merged
20 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？
🔗 相关 Issue
💡 需求背景和解决方案
☑️ 请求合并前的自查清单
Summary by CodeRabbit
新功能
改进