Skip to content

feat(menuitem): add css classnames to enhance custom style abilities#2443

Merged
xiaoyatong merged 2 commits intojdf2e:nextfrom
Miles-hxy:hxy/715/menu
Jul 19, 2024
Merged

feat(menuitem): add css classnames to enhance custom style abilities#2443
xiaoyatong merged 2 commits intojdf2e:nextfrom
Miles-hxy:hxy/715/menu

Conversation

@Miles-hxy
Copy link
Collaborator

@Miles-hxy Miles-hxy commented Jul 15, 2024 •
edited by coderabbitai bot
Loading

chore(menuitem): 新增css类名，增强自定义样式能力

  • 代码风格优化

Summary by CodeRabbit

  • 新功能

    • 在 MenuItem 组件中添加了图标的条件渲染功能。如果图标存在，将克隆并添加额外的样式类；否则，将渲染默认的 Check 图标，并应用修改后的样式类名。

  • 样式

    • 更新了图标和标题元素的类名，分别为 "nut-menu-container-item-icon" 和 "nut-menu-container-item-title"。

@coderabbitai
Copy link

coderabbitai bot commented Jul 15, 2024 •
edited
Loading

Walkthrough

在 MenuItem 组件中，图标渲染逻辑进行了更新。现在，如果存在图标，将条件性地克隆该图标并添加额外的类名，否则将渲染一个带有修改类名的默认 Check 图标。此外，图标和标题元素的类名也进行了调整。

Changes

文件路径 变更摘要
src/packages/menuitem/menuitem.taro.tsx 对 MenuItem 组件中图标渲染逻辑进行更新，添加类名 nut-menu-container-item-icon 到图标，并修改标题元素类名为 nut-menu-container-item-title。
src/packages/menuitem/menuitem.tsx 在 <i> 元素中增加类名 "nut-menu-container-item-icon"，并修改 <div> 元素的类名，包含 "nut-menu-container-item-title" 和 getIconCName(item.value, value) 的结果。

Sequence Diagram(s)

本次变更不涉及新的功能或控制流程的修改，因此不需要生成序列图。

Possibly related issues

Poem

代码小改动，改变大不同，
图标标题样，类名皆附上。
样式更灵活，用户笑开颜，
MenuItem 更强，前端乐无边。
🐰💻✨

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

‼️ IMPORTANT
Auto-reply has been disabled for this repository in the CodeRabbit settings. The CodeRabbit bot will not respond to your replies unless it is explicitly tagged.

  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@Miles-hxy Miles-hxy linked an issue Jul 15, 2024 that may be closed by this pull request
[FR]: Menu.Item 组件中 nut-menu-container-item 下的两个组件缺少类名 #2440
Closed
@Miles-hxy Miles-hxy changed the title chore(menuitem): add css classnames to enhance custom style abilities feat(menuitem): add css classnames to enhance custom style abilities Jul 16, 2024
@xiaoyatong xiaoyatong merged commit 4047426 into jdf2e:next Jul 19, 2024
@Miles-hxy Miles-hxy deleted the hxy/715/menu branch November 19, 2024 10:44
@coderabbitai coderabbitai bot mentioned this pull request Apr 21, 2025
Merged
20 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

size/S

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FR]: Menu.Item 组件中 nut-menu-container-item 下的两个组件缺少类名

2 participants

@Miles-hxy @xiaoyatong