Fix CNF image copy to work cross subscription#98
Closed
sunnycarter wants to merge 1 commit intoadd-aosm-extensionfrom
Closed
Fix CNF image copy to work cross subscription#98sunnycarter wants to merge 1 commit intoadd-aosm-extensionfrom
sunnycarter wants to merge 1 commit intoadd-aosm-extensionfrom
Conversation
Collaborator
Author
|
Decided to do this a different way that didn't change input.json and changed less code. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLOSING THIS PR because decided to do it a different way.
#72 introduced a bug for CNF image copy, where it only worked if the source and target ACR were in the same subscription.
https://learn.microsoft.com/en-us/azure/container-registry/container-registry-import-images?tabs=azure-cli#import-from-a-registry-in-a-different-subscription explains the syntax for
az acr importcross subscription and explains that this also works in the same subscription.This fixes that by using --registry in the command and having the image name as just repo/image:tag rather than containing the registry name as well.
Tested cross subscription with all three ways of image tranfser: