Add empty init files to inner modules so setuptools recognises them#5
Merged
PerfectChaos merged 1 commit intoadd-aosm-extensionfrom May 16, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After installing from the packaged wheel, any attempts to use commands beneath the top level "aosm" currently fail, because the submodules can't be found within the extension. This includes help commands:
A lengthy stack trace also follows, but the key thing here is that
generate_nfdis not found withinazext_aosm.This is because when building the list of packages to include we use
setuptools, specifically thefind_packages()function, which doesn't recognise this as a valid submodule because it lacks an__init__.py. The same is true of other modules within the extension, this just happens to be the one we hit first.