Add quotes to the CNF input config image sources comment#182
Merged
patrykkulik-microsoft merged 1 commit intomainfrom Apr 22, 2024
Merged
Add quotes to the CNF input config image sources comment#182patrykkulik-microsoft merged 1 commit intomainfrom
patrykkulik-microsoft merged 1 commit intomainfrom
Conversation
jordlay
reviewed
Apr 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jordan pointed out that one of the customers did not have quotes around their images sources in the screenshot of the config for their CNFs. This should result in a "invalid JSON" error which should be easy to fix. The problem is that we were actually not including quotes in the config comments which would mean that if the user does what we tell them to do, it will result in an error. That is not good. This PR fixes this minor omission.
I pointed this at the main branch because I don't think there is any risk to it. Let me know if you disagree.