Conversation
jordlay
reviewed
Mar 27, 2024
...atest/integration_tests/fixtures/core-vnf/core-vnf-input-with-filepath-with-vhd-params.jsonc
Outdated
Show resolved
Hide resolved
jordlay
reviewed
Mar 27, 2024
...ext_aosm/tests/latest/integration_tests/fixtures/core-vnf/core-vnf-input-with-filepath.jsonc
Outdated
Show resolved
Hide resolved
jordlay
reviewed
Mar 27, 2024
...integration_tests/integration_test_mocks/mock_input_templates/input_multiple_instances.jsonc
Show resolved
Hide resolved
jordlay
reviewed
Mar 27, 2024
...atest/integration_tests/integration_test_mocks/mock_input_templates/input_multi_nf_nsd.jsonc
Show resolved
Hide resolved
jordlay
reviewed
Mar 27, 2024
.../azext_aosm/tests/latest/integration_tests/scenario_tests/test_aosm_cnf_build_and_publish.py
Show resolved
Hide resolved
jordlay
reviewed
Mar 27, 2024
.../azext_aosm/tests/latest/integration_tests/scenario_tests/test_aosm_vnf_build_and_publish.py
Show resolved
Hide resolved
Collaborator
|
Looks fine overall, some of the details of the tests are beyond me but if they pass azdev test aosm and the live tests then they should be fine :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR to fix the tests which existed in the public CLI but were broken by the refactor. All tests pass both live and when running from the recording.
I have deleted the "broken tests" folder even though it contains useful tests because we should not have a "broken tests" folder in the public CLI. We should add this folder back in, in a separate branch (I made a task for it in my story)
A lot of the file changes in this PR are due to renaming and or re-arranging things