Conversation
Cyclam
reviewed
Mar 11, 2024
Comment on lines
+86
to
+96
|
|
||
| def _format_default_config(self): | ||
| print(self.default_config) | ||
| formatted_config = {} | ||
| for (key, value) in self.default_config.items(): | ||
| # This must be an integer, but is a string in the input file | ||
| if key == "image_disk_size_GB": | ||
| value = int(value) | ||
| formatted_key = snake_case_to_camel_case(key) | ||
| formatted_config[formatted_key] = value | ||
| return formatted_config |
Collaborator
There was a problem hiding this comment.
Is it not easier to do all this in the init(), perhaps like this:
if "image_disk_size_GB" in self.default_config:
self.default_config["imageDiskSizeGB"] = int(self.default_config["image_disk_size_GB"])
del self.default_config["image_disk_size_GB"]
(and if we know we always have image_disk_size_GB, then we don't need the if statement)
(and if it doesn't matter if the old value sticks around, don't need the del either)
Collaborator
Author
There was a problem hiding this comment.
we dont always have disk size + i like having a separate dict returned so we dont have to worry about deleting things
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We need to convert our vhd parameters to camel case, so that it doesn't fail on the SNS put.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.