Merged
Conversation
Cyclam
approved these changes
Jan 25, 2024
Collaborator
Cyclam
left a comment
There was a problem hiding this comment.
Really good stuff. One minor possible refactor, and some generaly thoughts on unit tests, but even without those changes it's good to merge, so hitting approve. Up to you if you do want to make the changes.
...azext_aosm/tests/latest/input_file_templates/input-nf-agent-cnf-template-invalid-chart.jsonc
Outdated
Show resolved
Hide resolved
src/aosm/azext_aosm/tests/latest/unit_test/test_helm_chart_processor.py
Outdated
Show resolved
Hide resolved
Cyclam
reviewed
Jan 30, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_find_image_linesfunction now points at the template generated by thehelm templatecommand to find lines that contain images. We no longer need recursive search because all images are in the template. We also wanted to make the image list a Set() because images should be unique_validate_helm_templatefunctionartifact.pyfunction to avoid infinite loop and trying to access undefined variablestest_pre_validate_build.pybecause point (2) has broken the testOnboardingCNFCLIHandlerthat has the correct config.