Add Helm template validation to the build method in the CLI#136
Merged
patrykkulik-microsoft merged 192 commits intomainfrom Jan 23, 2024
Merged
Add Helm template validation to the build method in the CLI#136patrykkulik-microsoft merged 192 commits intomainfrom
patrykkulik-microsoft merged 192 commits intomainfrom
Conversation
…and vhd processors
Add publisher command group to CLI
…onfig; added instructions for completing publish/delete
…s into cli-redesign
Co-authored-by: Jordan <jordan.layton@metaswitch.com>
Markups from publish PR --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: jordlay <72226943+jordlay@users.noreply.github.com>
Co-authored-by: Jordan <jordan.layton@metaswitch.com>
Collaborator
|
Could you update |
Collaborator
|
"I also noticed that none of our other custom exceptions inherit from errors like UserFault which is something that is recommended in the CLI. Should I change that in this PR?"
|
Cyclam
reviewed
Jan 22, 2024
Cyclam
reviewed
Jan 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is for [Turtle 2Wk09 (Jan 14 - Jan 27) Taskboard - Boards (azure.com)](https://dev.azure.com/msazuredev/AzureForOperators/_sprints/taskboard/Turtle/AzureForOperators/Germanium/CY24Q1/2Wk/2Wk09%20(Jan%2014%20-%20Jan%2027)?workitem=1085387)
This feature adds a
pre_validate()step to thebuildmethod of the CLI which validates the helm chart used in build by running a subprocess step with thehelm templatecommand.Changes:
pre_validate()function to the build step_validate_helm_templatefunction to perform the helm template validation for each of the charts. If there is an error in the validation I create an error file in the current working directory of the user using a jinja 2 template. I decided to do it in the current working directory because of the additional complexity that would have to be added if we were to create the folder in the build output folder or in a separate folderpath_to_mappingsproperty todefault_values. Functionally this property is the same, but Jacob thought it would be good to change the name and the description of itMissingDependency. I also noticed that none of our other custom exceptions inherit from errors likeUserFaultwhich is something that is recommended in the CLI. Should I change that in this PR?nf-agent-cnf-invalidfolder and it doesn’t need a review