Conversation
…and vhd processors
Add publisher command group to CLI
…onfig; added instructions for completing publish/delete
…s into cli-redesign
* Fix bug where the build directory wasn't deleted * Fix bug where the json wasn't output correctly * fixed incorrect merge fix --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com>
…def template, fixed artifact version in nsds, fixed vhd validation
…is relative to nsd output folder
…anged custom to take path
* Move artifact create from dict logic to instantiating code * Create CommandContext class to hold Azure clients and CLI options, and pass instance through to the delete and publish commands. * Mostly implemented and working publish. Lots of debug code still present. * Publish done and mostly tested. * Add some more logging. Remove help text referring to --order-params. * Update src/aosm/azext_aosm/common/artifact.py Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com> * fix merge conflicts --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Cyclam <95434717+Cyclam@users.noreply.github.com>
* fixed common params files for all * remove prints; remove sourcelocaldockerimage + add correct validation; edit input.json comments * fixed extract tar error * only create oras_client once - temp solution --------- Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com>
Co-authored-by: Jordan <jordan.layton@metaswitch.com>
Markups from publish PR --------- Co-authored-by: Andy Churchard <andy.churchard@metaswitch.com> Co-authored-by: Jordan <jordan.layton@metaswitch.com> Co-authored-by: jordlay <72226943+jordlay@users.noreply.github.com>
Co-authored-by: Jordan <jordan.layton@metaswitch.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.