General update for 2023-09-01 API#115
Merged
Cyclam merged 23 commits intoachurchard/regenerate-python-sdkfrom Oct 17, 2023
Merged
General update for 2023-09-01 API#115Cyclam merged 23 commits intoachurchard/regenerate-python-sdkfrom
Cyclam merged 23 commits intoachurchard/regenerate-python-sdkfrom
Conversation
added 13 commits
September 26, 2023 17:00
Collaborator
jamiedparsons
left a comment
There was a problem hiding this comment.
Looks good - a couple of very minor comments.
...osm/azext_aosm/tests/latest/scenario_test_mocks/mock_input_templates/cnf_input_template.json
Show resolved
Hide resolved
…by/azure-cli-extensions into andy/general-update-for-2023-09-01
…ate-for-2023-09-01
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional changes required to work with the 2023-09-01 API.
Reviewing is probably easiest commit by commit. Here they are, with commentary where it might be useful:
Update nf_template.bicep.j2 to use new NFDV resource reference property: Fix for bug found by Jen, that the network function API had changed too.
Testing
Tested CNF and VNF workflow, including SNS create.