Conversation
Python 3.12 changed module init slightly (this may actually be a CPython 3.12 bug, it's not 100% clear). Before Python 3.12 the module wouldn't be available via `PyState_FindModule` until it was fully initialized. Now the module is immediately available, but in an invalid state leading to segfaults. The workaround is to manually call `PyState_AddModule` to ensure the module is always available. In the long run we should move to using multiphase module init which should avoid this problem entirely.
Owner
Author
|
For additional context, the segfault here:
Rather than add a test for this esoteric issue, I've:
I'll cut a new release immediately after merging this. |
|
Thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 3.12 changed module init slightly (this may actually be a CPython 3.12 bug, it's not 100% clear). Before Python 3.12 the module wouldn't be available via
PyState_FindModuleuntil it was fully initialized. Now the module is immediately available, but in an invalid state leading to segfaults. The workaround is to manually callPyState_AddModuleto ensure the module is always available.In the long run we should move to using multiphase module init which should avoid this problem entirely.