Conversation
This adds support for attrs validators. Validators are run after decoding the instance has completed, but before calling `__attrs_post_init__`. Since the builtin attrs validators include the attribute name in the error message, we don't add the field to the error path. This feels *a bit* weird, but is way easier since all of this can be done in pure python. When possible, it'd be better to use msgspec's builtin constraints for handling validation. These will be much more performant, and integrate better with the rest of the system.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for attrs validators. Validators are run after decoding the instance has completed, but before calling
__attrs_post_init__. Since the builtin attrs validators include the attribute name in the error message, we don't add the field to the error path. This feels a bit weird, but is way easier since all of this can be done in pure python.When possible, it'd be better to use msgspec's builtin constraints for handling validation. These will be much more performant, and integrate better with the rest of the system.
Fixes #535.