Merged
Conversation
Follow up to jcrist#983 Sorry, I've missed that `json.pyi` exists :( Without this change mypy is not happy: ``` » mypy . dmr/plugins/msgspec/schema.py:23: error: Unexpected keyword argument "ref_template" for "schema" [call-arg] .venv/lib/python3.13/site-packages/msgspec/json.pyi: note: "schema" defined here Found 1 error in 1 file (checked 472 source files) ```
jcrist
approved these changes
Apr 8, 2026
Collaborator
|
I think we should cut a patch release for this. |
Owner
|
Lets hold off a few days, I have at least one more PR I want to get in and I suspect there may be others. |
Collaborator
|
@Siyet Starting right now I will be away for 2 weeks. Please feel free to merge and release fixes without our presence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #983 Sorry, I've missed that
json.pyiexists :(Without this change mypy is not happy: