improve on read-only targets, see issue #202#228
Closed
ThomasWaldmann wants to merge 2 commits intojborg:masterfrom
ThomasWaldmann:fix_ro_target
Closed
improve on read-only targets, see issue #202#228ThomasWaldmann wants to merge 2 commits intojborg:masterfrom ThomasWaldmann:fix_ro_target
ThomasWaldmann wants to merge 2 commits intojborg:masterfrom
ThomasWaldmann:fix_ro_target
Conversation
Without this, you just got "RCPError: AttributeError", now you get (e.g.): RPCError: AttributeError(b"'Repository' object has no attribute 'segments'",)
Contributor
Author
|
closing this pull request, seems unwanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it now fails in the same way for remote r/o targets as for local r/o targets (with a write lock exception).
with a remote target, the Repository instance seems to survive exceptions and thus the wrong self._txn_state lead to the strange behaviour that can be seen in the traceback of issue #202.
i am not completely sure whether this is the best solution, please review.