Misc. Fixes / Improvements#206
Closed
ThomasWaldmann wants to merge 5 commits intojborg:masterfrom
ThomasWaldmann:fixes
Closed
Misc. Fixes / Improvements#206ThomasWaldmann wants to merge 5 commits intojborg:masterfrom ThomasWaldmann:fixes
ThomasWaldmann wants to merge 5 commits intojborg:masterfrom
ThomasWaldmann:fixes
Conversation
…ile object, also do a flush first)
|
You really should limit the first line of your commit messages to the customary 50 characters for legibility. |
Contributor
Author
|
opinions? suggestions? code review? |
Contributor
Author
|
@jborg also very simple and easy stuff. |
Contributor
Author
|
closing this pull request, seems unwanted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is some stuff pycharm's code checker has discovered.
thanks for attic!