Skip to content

allow to add files in dot-directories#11

Closed
niol wants to merge 9 commits intojbernard:developfrom
niol:develop
Closed

allow to add files in dot-directories#11
niol wants to merge 9 commits intojbernard:developfrom
niol:develop

Conversation

@niol
Copy link
Contributor

@niol niol commented Oct 2, 2012

This is especially usefull for applications that mix state files and
configuration files in their dot-directory, for instance :

  • .unison which contains *prf and state files
  • .lftp which contains rc (conf file) and log, cwd_history.

niol added 2 commits October 2, 2012 12:19
@niol
allow to add files in dot-directories
95068c6 
This is especially usefull for applications that mix state files and
configuration files in their dot-directory, for instance :
  - .unison which contains *prf and state files
  - .lftp which contains rc (conf file) and log, cwd_history.
@niol
fix dotfile name display in error messages
581a77c
@jbernard
Copy link
Owner

jbernard commented Oct 3, 2012

Thanks for the patch! From a glace, it looks almost there, but it breaks the list and check commands. If you can fix this up, I'll be happy to merge it.

@niol
Copy link
Contributor Author

niol commented Oct 3, 2012

Hi,

Thanks for the patch! From a glace, it looks almost there, but it breaks
the list and check commands. If you can fix this up, I'll be happy to merge
it.

Do you have a use case to reproduce the error?

Thanks,

Alex

@jbernard
Copy link
Owner

jbernard commented Oct 3, 2012

  • niol notifications@github.com wrote:

    Hi,

    Thanks for the patch! From a glace, it looks almost there, but it breaks
    the list and check commands. If you can fix this up, I'll be happy to merge
    it.

    Do you have a use case to reproduce the error?

If your dotfiles are in a directory under VCS, git for example. The switch from
os.listdir() to os.walk() seems to pick up the contents of the .git directory
and lists them as 'missing'. This could be a different bug though, I haven't had
a chance to dig further yet.

Cheers,

Jon

niol added 3 commits October 4, 2012 08:18
@niol
do not pick up the contents of VCS directories in the repository
0b09d51
@niol
use relative symlinks
416e796 
This avoids broken symlinks when manipulating a chroot'ed installation from
the host.
@niol
manage multiple hosts in the repository
b6fd740 
If there is a 'all.host' directory in the repository, dotfiles enables
hosts mode: you now can add a dotfile to a particular host, and any sync
will create symlinks for dotfiles in the 'hostname.host' directory as well
as for the ones in the 'all.host' directory.
@niol
Copy link
Contributor Author

niol commented Oct 4, 2012

If your dotfiles are in a directory under VCS, git for example. The switch
from
os.listdir() to os.walk() seems to pick up the contents of the .git
directory
and lists them as 'missing'. This could be a different bug though, I
haven't had
a chance to dig further yet.

This is a different bug, I fixed it by ignoring dot directories in the
repository.

I also implemented two more features that you may find usefull.

Alex

@jbernard
Copy link
Owner

jbernard commented Oct 11, 2012

  • niol notifications@github.com wrote:

    If your dotfiles are in a directory under VCS, git for example. The switch
    from
    os.listdir() to os.walk() seems to pick up the contents of the .git
    directory
    and lists them as 'missing'. This could be a different bug though, I
    haven't had
    a chance to dig further yet.

    This is a different bug, I fixed it by ignoring dot directories in the
    repository.

    I also implemented two more features that you may find usefull.

Great, I will look at these hopefully soon. I do suspect these changes may cause
problems with users upgrading from older versions - which isn't necessarily
a bad thing, but I need to examine it from this perspective as well to make sure
there's a reasonable path forward.

Cheers

Jon

@daenney
Copy link

daenney commented Jan 3, 2013

+1. I just ran into the issue that dotfiles told me ~/.bundle/config is not a dot-file. Which in truth it isn't but I'd still like to add it 😄.

@niol
Merge version 0.5.5
e8b82dc 
Conflicts:
	dotfiles/core.py
@pablox-cl
Copy link

pablox-cl commented Jan 28, 2013

There are some regressions in the code! Regarding python3 incompatible syntax.

(A lot of print "..., instead of print("....)

@jbernard
Copy link
Owner

jbernard commented Jan 30, 2013

This is helpful. I intend to take a serious look at this as soon as some time frees up.

@flupke flupke mentioned this pull request Feb 9, 2013
Merged
niol added 2 commits February 13, 2013 10:06
@niol
Merge new Packages feature
af973e8 
Conflicts:
	README.rst
	dotfiles/cli.py
	dotfiles/core.py
@niol
Merge version 0.6
a7054c4
@sevein
Copy link
Contributor

sevein commented Feb 26, 2013

Awesome, I love it! Thanks.

@jbernard jbernard closed this Nov 7, 2013
@jbernard
Copy link
Owner

jbernard commented Nov 8, 2013

Oh wow, is seems that deleting a branch that a pull-request is based on will close that pull-request automatically. This is not what I intended, I'll rebase this branch against master and resubmit. Sorry about that.

@niol niol deleted the develop branch November 13, 2013 11:45
@niol niol mentioned this pull request Nov 13, 2013
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@niol @jbernard @daenney @pablox-cl @sevein