Include cmake files in install#344
Conversation
There was a problem hiding this comment.
What's this OPENSURGSIM_CMAKE_DIR?
There was a problem hiding this comment.
Looks like some of this was taken from this project. Definitely not standard. Needs to be edited out.
There was a problem hiding this comment.
Oops, yes this is a mistake.
|
I'm getting: When running cmake on a clean build. Would my branch perform the same as this PR? The edits I've made are much simpler. |
|
@theNerd247 Does the latest version fix your issue? |
|
I'm getting the same error as @theNerd247 above. |
|
For me it builds and installs fine, cmake 3.4.1 here. |
|
Interesting, I'm getting the error with cmake 3.1.x, but it succeeds when upgrading to 3.4.x. Paul, any idea why? |
|
I just tried it with cmake 3.0, and I can now reproduce the error. I'll On Sun, Jan 31, 2016, at 01:02 PM, Jesse Beder wrote:
Links: |
|
Since the maintainer is not notified if someone only pushes to a PR branch, I post a reminder comment, the commit message suggests Paul fixed it. |
|
Please test this again and merge eventually. |
|
Looks good, sorry for the delay. Please squash these commits and rebase against HEAD. |
This adds yaml-cpp-config.cmake, yaml-cpp-config-version.cmake, and yaml-cpp-targets.cmake to the cmake install. As a result, cmake's find_package can easily find yaml-cpp for software that depends on yaml-cpp. Add code to install cmake files to $CMAKE_INSTALL_PREFIX/CMake on Windows, which is the de-facto standard. Closes jbeder#336 jbeder#127
|
@jbeder Ok, I think it is all set. |
|
Just a tip: use GNUInstallDirs for pretty variables of the install destination. |
|
This contains some unneeded changes. Will create a cleanup PR then. |
|
How to use it? |
|
@DinoStray Don't use it at all, CMake variables are deprecated... see #661 |
This adds yaml-cpp-config.cmake, yaml-cpp-config-version.cmake, and
yaml-cpp-targets.cmake to the cmake install. As a result, cmake's
find_package can easily find yaml-cpp for software that depends on
yaml-cpp.
Closes #336 #127