Skip to content

Stomping on build flags #634

@joelfrederico

Description

@joelfrederico

yaml-cpp/CMakeLists.txt

Lines 144 to 147 in 774f258

# GCC or Clang or Intel Compiler specialities
if(CMAKE_CXX_COMPILER_ID MATCHES "GNU" OR
CMAKE_CXX_COMPILER_ID MATCHES "Clang" OR
CMAKE_CXX_COMPILER_ID MATCHES "Intel")

yaml-cpp/CMakeLists.txt

Lines 161 to 164 in 774f258

set(CMAKE_CXX_FLAGS_RELEASE "-O2")
set(CMAKE_CXX_FLAGS_RELWITHDEBINFO "-O2 -g")
set(CMAKE_CXX_FLAGS_DEBUG "-g")
set(CMAKE_CXX_FLAGS_MINSIZEREL "-Os")

There is a Clang compiler for Windows, and stomping on the existing flags is not a good idea anyways. Why not just leave the flags alone? CMake has sensible defaults and people can override them if they want to.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions