add CopyGetter for some attributes which are copyable#29
Merged
Hoverbear merged 4 commits intojbaublitz:masterfrom Sep 8, 2019
bachue:master
Merged
add CopyGetter for some attributes which are copyable#29Hoverbear merged 4 commits intojbaublitz:masterfrom bachue:master
Hoverbear merged 4 commits intojbaublitz:masterfrom
bachue:master
Conversation
Hoverbear
reviewed
Sep 1, 2019
Co-Authored-By: Ana Hobden <operator@hoverbear.org>
Collaborator
Hoverbear
reviewed
Sep 4, 2019
Hoverbear
requested changes
Sep 4, 2019
This was referenced Sep 4, 2019
Closed
Closed
djc
reviewed
Sep 6, 2019
Contributor
djc
left a comment
There was a problem hiding this comment.
Sorry, took me a little bit to get to this.
Looks good to me, one minor nit!
Hoverbear
approved these changes
Sep 8, 2019
Collaborator
|
Failing CI is because Travis windows is bad at caching, merging. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.