Support non-identifier visibility like pub(crate)#28
Merged
Hoverbear merged 5 commits intojbaublitz:masterfrom Sep 1, 2019
Merged
Support non-identifier visibility like pub(crate)#28Hoverbear merged 5 commits intojbaublitz:masterfrom
Hoverbear merged 5 commits intojbaublitz:masterfrom
Conversation
12 tasks
|
This would be very helpful for nushell (nushell/nushell#362), maybe @djc even made it with nushell in mind. After this a new crates.io release would be really great. Thanks! |
Contributor
Author
|
This was indeed done with nu shell in mind. 👍 |
Hoverbear
approved these changes
Sep 1, 2019
Collaborator
Hoverbear
left a comment
There was a problem hiding this comment.
LGTM! I tried to add this back in the first impl but it wasn't stable yet. :(
| quote = "0.6.10" | ||
| syn = "0.15.21" | ||
| proc-macro2 = { version = "0.4.24", default-features = false } | ||
| quote = "1" |
Collaborator
|
Thanks for this @djc , been on vacation this last week. :) |
|
It would be great if this is documented in the get-started example:) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This also upgrades to syn-1.
Sorry again for the callout on Twitter, I normally don't worry much about "public" Twitter mentions (and DMs don't always work) but should have appreciated that others might.