Fixed metadata and improved test script#20
Merged
Hoverbear merged 2 commits intojbaublitz:masterfrom Jan 7, 2019
Razican:small_fixes
Merged
Fixed metadata and improved test script#20Hoverbear merged 2 commits intojbaublitz:masterfrom Razican:small_fixes
Hoverbear merged 2 commits intojbaublitz:masterfrom
Razican:small_fixes
Conversation
Hoverbear
reviewed
Jan 7, 2019
| os: | ||
| - linux | ||
| - osx | ||
| - windows |
Hoverbear
reviewed
Jan 7, 2019
| # Run builds in Linux, MacOS X and Windows | ||
| os: | ||
| - linux | ||
| - osx |
Collaborator
There was a problem hiding this comment.
We found this can dramatically slow down test feedback since the queue for Mac machines can get quite long. But it's fine. :)
Hoverbear
approved these changes
Jan 7, 2019
Collaborator
|
This looks great. Thank you so much. Regarding auto deploy: For the time being I think it's overkill. Regarding kcov: Please, open an issue with instructions and I'll happily do it. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi!
I fixed the badges for crates.io, and I added Windows and OS X tests. I also added tests for Rust beta and the lowest supported Rust version (1.19). It now also tests for format errors and it runs a clippy pass.
Since it tests for Windows in Travis, there is no need for Appveyor, so I removed the YAML file and the badge. I can add it back, of course. I would like to add code coverage reports with kcov, but @Hoverbear has to set it up.
We can also add automatic Travis-CI deployment on tags, but it requires a crates.io token that has to be added to the Travis-CI environment in travis-ci.org, and that would make Windows builds fail randomly, due to a bug in Travis-CI.