Skip to content

feat: Document using JBang on Windows, improve diagnosability of symbolic linking issues#898

Merged
maxandersen merged 5 commits into
jbangdev:mainfrom
oleg-nenashev:windows-symlinks-enhancements
May 29, 2021
Merged

feat: Document using JBang on Windows, improve diagnosability of symbolic linking issues#898
maxandersen merged 5 commits into
jbangdev:mainfrom
oleg-nenashev:windows-symlinks-enhancements

Conversation

@oleg-nenashev

@oleg-nenashev oleg-nenashev commented May 29, 2021

Copy link
Copy Markdown
Contributor
  • Document using JBang on WIndows, esp. symbolic link concerns
  • Update contributing guidelines so clarify the environment expectations
  • Add assumptions to the failing unit test
  • Add diagnostics messaging to JBang execution

Closes #895

@oleg-nenashev oleg-nenashev changed the title Document using JBang on Windows, improve diagnosability of symbolic linking issues rfe,docs: Document using JBang on Windows, improve diagnosability of symbolic linking issues May 29, 2021
@oleg-nenashev oleg-nenashev changed the title rfe,docs: Document using JBang on Windows, improve diagnosability of symbolic linking issues chore,docs: Document using JBang on Windows, improve diagnosability of symbolic linking issues May 29, 2021
@oleg-nenashev oleg-nenashev changed the title chore,docs: Document using JBang on Windows, improve diagnosability of symbolic linking issues feat,docs: Document using JBang on Windows, improve diagnosability of symbolic linking issues May 29, 2021
@quintesse

Copy link
Copy Markdown
Contributor

LGTM so far 👍

@oleg-nenashev oleg-nenashev changed the title feat,docs: Document using JBang on Windows, improve diagnosability of symbolic linking issues feat: Document using JBang on Windows, improve diagnosability of symbolic linking issues May 29, 2021

} catch (RuntimeException e) {
throw new ExitException(1, "Could not resolve dependency", e);
throw new ExitException(1, "Could not resolve dependency " + it, e);

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated one-liner

@oleg-nenashev oleg-nenashev marked this pull request as ready for review May 29, 2021 10:53
@maxandersen maxandersen merged commit 478f0c8 into jbangdev:main May 29, 2021
@maxandersen

Copy link
Copy Markdown
Collaborator

@all-contributors please add @oleg-nenashev for code

@allcontributors

Copy link
Copy Markdown
Contributor

@maxandersen

I've put up a pull request to add @oleg-nenashev! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

JBang failures on Windows when symlinks are allowed in the FileSystem

3 participants