Rewrite absolute path as relative to the destination requirements.txt file#673
Closed
maciej-gol wants to merge 8 commits intojazzband:masterfrom
Closed
Rewrite absolute path as relative to the destination requirements.txt file#673maciej-gol wants to merge 8 commits intojazzband:masterfrom
maciej-gol wants to merge 8 commits intojazzband:masterfrom
Conversation
Author
|
Adding the co-author @AmiroNasr to the conversation. |
Author
|
Tests are failing because of broken newest pip integration. |
|
Waiting for this...!!! |
3 tasks
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a fix to a pull request made by @orf . This time, it resolves absolute path relative to the destination requirements file, making it work regardless you call pip-compile as long as you don't move the destination file around.
Changelog-friendly one-liner: Rewrite absolute path as relative to the destination requirements.txt file
Contributor checklist