Closed
Conversation
It doesn't add anything that an autogenerated manager cannot provide.
Contributor
Author
|
The docs ( |
Contributor
|
The I don't like breaking code so maybe we should just ignore them for mypy and remove them in de future? |
Contributor
Author
That would be fine with me. The main thing I want to avoid is a user getting a worse type checking experience because they're not aware that there is a better supported alternative. I'll close this PR and open a new one to deprecate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
JoinManagerclass doesn't provide anything that is not already provided byJoinQueryset.as_manager().My main motivation for removing
JoinManageris that it would be too much work to makeJoinManagerwork properly with type annotations, whileas_manager()works out of the box thanks to the django-stubs plugin.This is a backwards incompatible change, as code using
JoinManagerorJoinManagerMixinwould have to be updated. In most cases, I expect that update to be a single-line change; see the unit test changes for an example.I don't know whether
JoinQuerysetis still relevant functionality. It generates SQL as a string and contains custom quote code, which always makes me worried about the potential for injection attacks. Perhaps that class could be removed as well?