Auto-generate manager implementation for CustomSoftDelete#612
Merged
foarsitter merged 3 commits intojazzband:masterfrom Apr 17, 2024
Merged
Conversation
Besides requiring less code, this also allows the django-stubs mypy plugin to automatically generate a type-annotated version of the manager. Unfortunately, the plugin does not put a `ClassVar` annotation on `objects`, which is why we need the suppression.
The `CustomSoftDeleteQuerySet` class was the only code left in the `test.managers` module, while it is not in fact a `Manager`.
Use the `available_objects` manager instead.
14ac0b4 to
512d0f1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #612 +/- ##
==========================================
- Coverage 98.94% 98.93% -0.01%
==========================================
Files 6 6
Lines 757 750 -7
==========================================
- Hits 749 742 -7
Misses 8 8 ☔ View full report in Codecov by Sentry. |
foarsitter
approved these changes
Apr 17, 2024
Contributor
foarsitter
left a comment
There was a problem hiding this comment.
Only touches the tests, Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides requiring less code, this also allows the django-stubs mypy plugin to automatically generate a type-annotated version of the manager.
Name the manager
available_objectsbecauseobjectsis deprecated inSoftDeletableModel.