Modernize the way some keyword-only arguments are implemented#606
Merged
foarsitter merged 2 commits intojazzband:masterfrom Apr 3, 2024
Merged
Modernize the way some keyword-only arguments are implemented#606foarsitter merged 2 commits intojazzband:masterfrom
foarsitter merged 2 commits intojazzband:masterfrom
Conversation
Keyword-only arguments can be used now that Python 2 is no longer supported.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #606 +/- ##
==========================================
- Coverage 98.57% 98.56% -0.01%
==========================================
Files 6 6
Lines 773 769 -4
==========================================
- Hits 762 758 -4
Misses 11 11 ☔ View full report in Codecov by Sentry. |
foarsitter
approved these changes
Apr 3, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python 2 didn't have keyword-only arguments, so some code emulated them by wrangling
kwargs. This PR updates that code to use modern syntax instead.There should be no backwards compatibility issues.