Forward additional arguments to contribute_to_class() to Django#605
Merged
foarsitter merged 2 commits intojazzband:masterfrom Apr 3, 2024
Merged
Forward additional arguments to contribute_to_class() to Django#605foarsitter merged 2 commits intojazzband:masterfrom
contribute_to_class() to Django#605foarsitter merged 2 commits intojazzband:masterfrom
Conversation
In Django 3.2 there is an additional argument `private_only` and more could be added in future versions.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #605 +/- ##
=======================================
Coverage 98.57% 98.57%
=======================================
Files 6 6
Lines 773 773
=======================================
Hits 762 762
Misses 11 11 ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
contribute_to_class()methods inStatusField,MonitorFieldandSplitFieldwere not passing on additional arguments to Django, which means theprivate_onlyargument and any future arguments could not be used. This PR fixes that by accepting and forwarding any additional arguments.